Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#390] event based comm example cpp #524

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Nov 24, 2024

Notes for Reviewer

Ports the rust event_based_communication example to C++.

Additionally, introduce FileDescriptorBased and implement it for FileDescriptorView so that WaitSet::attach_**() can be handled easier and the user does not have to acquire low-level implementation details like the file descriptor.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #390

@elfenpiff elfenpiff self-assigned this Nov 24, 2024
@elfenpiff elfenpiff force-pushed the iox2-390-event-based-comm-example-cpp branch from 437ceef to 15f2f35 Compare November 24, 2024 15:23
@elfenpiff elfenpiff force-pushed the iox2-390-event-based-comm-example-cpp branch from 15f2f35 to c766160 Compare November 24, 2024 15:30
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.82%. Comparing base (3d5f942) to head (4b68d49).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   78.88%   78.82%   -0.06%     
==========================================
  Files         201      201              
  Lines       24220    24220              
==========================================
- Hits        19106    19092      -14     
- Misses       5114     5128      +14     

see 3 files with indirect coverage changes

@elfenpiff elfenpiff requested a review from elBoberido November 25, 2024 22:38
@elfenpiff elfenpiff force-pushed the iox2-390-event-based-comm-example-cpp branch from 8c67b11 to b2db0fd Compare November 25, 2024 22:42
@elfenpiff elfenpiff requested a review from orecham November 26, 2024 16:32
@elfenpiff elfenpiff merged commit 521f7cf into eclipse-iceoryx:main Nov 27, 2024
45 checks passed
@elfenpiff elfenpiff deleted the iox2-390-event-based-comm-example-cpp branch November 27, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iceoryx WaitSet integration
3 participants